Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31160

Update getSelectorFromElement to handle invalid selectors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/janklimo/janklimo-fix-get-selector-from-element into main Jun 24, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: janklimo

Bootstrap v5 introduced a regression wherein an unhandled DOMException would be thrown if initialising a dropdown element on an anchor tag with a standard URL in the href tag.

This is a realistic scenario when the UI shows dropdown on hover but still allows the user to click the link.

This PR adds error handling for this scenario and a spec to cover the change, essentially reimplementing how this is handled in v4:

https://github.com/twbs/bootstrap/blob/4f44a2afd0acbf8a2d199c6fffe619b91dee1c99/js/src/util.js#L88-L92

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/janklimo/janklimo-fix-get-selector-from-element