Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31285

Add side modals

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Otto requested to merge side-modals into main Jul 12, 2020
  • Overview 1
  • Commits 5
  • Pipelines 0
  • Changes 3

This PR adds two new modifier classes to our .modal component, .modal-left and .modal-right. It uses these two classes to create offcanvas drawers for navigation, content, and more. I've included two slightly different examples for now: a nav component and a list group component. I'm thinking a new example (perhaps a sidebar shopping cart or additional dashboard layout) could help show more of this off, too.

Still needs more work, but wanted to capture the idea from comments in #29017.

Source: https://bootstrap-menu.com/detail-modal.html by @vosidiy

Fixes #27033 (closed), fixes #24718 (closed).


Demo: https://deploy-preview-31285--twbs-bootstrap.netlify.app/docs/5.0/components/modal/#sidebar-modals

Screen Shot 2020-07-12 at 10 50 47 AM

This could also probably be backported—thoughts?

TODO:

  • Allow customizing side modals transition?
  • Nuke the off canvas example or adapt it to use this solution?
  • Fix the right padding issue
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: side-modals