Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31518

#25110 Missing border radius on input group with validation feedback

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dejakob/v5-25110 into main Aug 21, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: dejakob

Issue reported

With new beta 3 and using the new input-group stuff, inputs inside input-groups with some validation feedback after them are missing the border-radius.

See: #25110

34426369-e70a858c-ec35-11e7-86f4-f178276e1f6e

Cause of issue

There is a selector in _input-group.scss that sets border-radius to 0 on all elements within an input-group that are not a dropdown or the last element:

.input-group {
  > :not(:last-child):not(.dropdown-toggle):not(.dropdown-menu)

Proposed solution

I added an extra pseudo-selector to check if there is no .invalid-feedback element coming after it, before overriding the border-radius to 0.

Screenshot 2020-08-21 at 14 11 48
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dejakob/v5-25110