Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31735

Simplify `make-container()`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge main-fod-simpler-make-container into main Sep 24, 2020
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: ffoodd

By dividing in the custom property directly:

  1. code is shorter,
  2. a single stylelint-disable rule
  3. easier override for paddings since we only have to change the custom property—without having to think about multiplying what we want by 2.

Any thoughts?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-fod-simpler-make-container