Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !318

bootstrap-twipsy ender support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rvagg/endersupport into master Sep 28, 2011
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: rvagg

Twipsy doesn't currently work with Ender for the following reasons:

ender.support isn't defined (as far as I can see anyway, perhaps there is a package that has it?). Seems like something that could go in to bowser though.

ender.data() is only bound to the internal chain so can't be called as $.data(e, k, v) but as far as I'm aware $(e).data(k, v) is fine by both Ender and jQuery. Perhaps bonzo.data should be bound to ender as well as boosh?

ender.remove() doesn't clean up like jQuery's does which leaves transitionEnd bound so on subsequent show()'s you get an immediate fade-out after the fade-in. An explicit unbind() seems to do the trick.

ender.fn doesn't actually do anything as far as I can tell so it seems appropriate to do an ender.ender(ender.fn, true) at the end of Twipsy to install it properly. Or perhaps just ender.ender({twpsy: ender.fn.twipsy, true) would be safest?

This pull request added Ender support and adds a little note about the dependencies. Let me know if you want anything adjusted.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rvagg/endersupport