Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31834

tooltip/popover: add a `customClass` option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/remeika/additional-classes-on-popover into v4-dev Oct 05, 2020
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 5

Created by: remeika

Please squash before merging

Fixes #19415 (closed)

Add extra classes to Tooltips and Popovers using the additionalClasses option, using $.addClass() behind the scenes.

Details:

  • Additional classes are evaluated and added every time the show() command is run. This should be idempotent, and allows the class list to be updated every time the component is shown.
  • New classes are added after the component template is hydrated in the DOM; if classes are added to a custom template and using additionalClasses, both will show up.

Questions I still have:

  • I targeted this release at the 4.X branch. I am not sure if I did the right thing there, rather than basing my work off main.
  • It looks like the file size of bootstrap.bundle.js has been locked in place: adding any additional code causes the build pipeline to fail. I'm wondering what course of action an individual contributor should take in this situation: Is the 4.X branch feature-locked? Should I try to delete some code elsewhere to try to squeeze under the limit? Should I just raise the limit?
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/remeika/additional-classes-on-popover