Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31955

Drop custom file upload plugin in favor of CSS solution

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge main-mc-form-file into main Oct 22, 2020
  • Overview 4
  • Commits 3
  • Pipelines 0
  • Changes 16

Created by: MartijnCuppens

CSS only alternative solution for https://github.com/twbs/bootstrap/pull/31085. Advantages:

  • No js dependencies
  • No need to add translated button labels
  • Labels are automatically adjusted when with <input type="file" multiple>

TODO:

  • Wait until legacy Edge is dropped This isn't really necessary, since legacy Edge already has a decent fallback
  • Extend migration guide
  • Check if the alpha version is correct
  • Fix border radii on iOS

https://deploy-preview-31955--twbs-bootstrap.netlify.app/docs/5.0/forms/form-control/#file-input https://deploy-preview-31955--twbs-bootstrap.netlify.app/docs/5.0/forms/validation/#supported-elements

Closes #30265 (closed) Closes #31085

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-mc-form-file