Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !32179

Don't hide modal when `config.keyboard` is false

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rohit2sharma95/modal-keyboard into main Nov 17, 2020
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: rohit2sharma95

Closes #30929 (closed)

Modal will not be closed with esc key when modal's configuration has keyboard:false and backdrop is not static. It will trigger the _triggerBackdropTransition() method to show the animation though. But I am not sure if modal should show animation when pressing esc key and modal's backdrop is not static. 🤔

Should I add/update the unit tests if it is okay? 🙂

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rohit2sharma95/modal-keyboard