Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !32439

Decouple BackDrop from modal

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged GeoSot requested to merge github/fork/GeoSot/baackdrop-as-separate-module into main Dec 11, 2020
  • Overview 4
  • Commits 5
  • Pipelines 0
  • Changes 7

Based on a comment was post on offcanvas merge request, I did a first approach to decouple Backdrop from Modal, for further usage and to simplify Modal code.

It misses the extra tests and a class modification, but they can be done, if you like it

Preview: https://deploy-preview-32439--twbs-bootstrap.netlify.app/docs/5.0/components/modal/

TODO:

  • Revert the class name change since it's a breaking one
  • Revert any further breaking changes like variable names, new backdrop.scss file etc
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/GeoSot/baackdrop-as-separate-module