Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !32631

Remove old/unnecessary reboot bug fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Patrick H. Lauke requested to merge patrickhlauke-remove-cargocult-forced-focus into main Dec 27, 2020
  • Overview 9
  • Commits 4
  • Pipelines 0
  • Changes 1

From initial testing, this bug ("transparent button background results in a loss of the default button focus styles") doesn't seem to manifest itself anywhere in Bootstrap (since we don't just set transparent background anywhere on buttons, and when we do set explicit button styles in the more specific stylings, we already do create a custom :focus style anyway)

Incidentally, this forced definition of :focus is biting us in the rear because it essentially circumvents the browser logic that only applies focus outline based on the browser's heuristic (i.e. not applying the button outline when clicked with a mouse). this forces the focus style to always show even after a mouse click, which is causing is hassle that we then need to work around - see https://github.com/twbs/bootstrap/pull/32630

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: patrickhlauke-remove-cargocult-forced-focus