Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !32882

Add function type for `popperConfig` option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge rohit/main/popper-config-function into main Jan 23, 2021
  • Overview 4
  • Commits 4
  • Pipelines 0
  • Changes 9

Created by: rohit2sharma95

Since shallow merge is used to merge popperConfig passed by the user for popper's config, this overrides the modifiers property instead of merging the array.

So creating popperConfig a function and then passing the default configuration as an argument gives users the ability to use the default configuration and merge it with their configuration. Keeping the previous type object in the supported types since removing it would be a breaking change.

Ref: https://github.com/twbs/bootstrap/pull/32443#issuecomment-748806985

@XhmikosR Let me know if it is a good idea 🙂

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rohit/main/popper-config-function