Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33368

Split colors from _variables.scss

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Otto requested to merge split-vars-colors into main Mar 15, 2021
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 10

This PR introduces a new Sass partial, _colors.scss, to help improve the structure of our code base given Sass's limitations around re-assigning variables. This should allow folks to use our own color variables in their customization more easily. Arguably this could be considered a breaking change, so we'll want to be careful about this.


TBD if we break out further variables... if we wanted to, some ideas could include:

  • _settings.scss to house our $enable- options, escaped characters, and variable prefix.
  • _grid.scss to house our breakpoints, containers, and more.
  • _type.scss for all typography

Not 100% final on anything, but potentially worth discussing while we're evaluating this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: split-vars-colors