Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33421

Revamp Scrollspy using Intersection observer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged GeoSot requested to merge gs-scrollspy-wth-intersection_observer into main Mar 22, 2021
  • Overview 22
  • Commits 22
  • Pipelines 0
  • Changes 7

Based on #33015.

Seems operational on the preview scrollspy page.

Needs:

  • Documentation
  • tweak tests

Advantages:

  • No need of relative/overflowing wrappers etc
  • Keeps offset config as deprecated, for backwards compatibility
  • Emits "activate" events in the same element that was initialized on, discarding the previous incompatibility where in case of body initialization, event was emitting to window

Disadvantages:

  • The method option is ignored now
  • all first observables, get the active class on first render

closes #35727 (closed) closes #33943 (closed) closes #28638 (closed) closes #35796 (closed) closes #28807 (closed) may fix #35628 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs-scrollspy-wth-intersection_observer