Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33582

Update navbar.md

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/bravogeorge/patch-1 into main Apr 08, 2021
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: bravogeorge

https://github.com/react-bootstrap/react-bootstrap/issues/5752

Regarding issues raised in the link above by @kyletsang I am proposing the following changes this document:

https://getbootstrap.com/docs/5.0/components/navbar/

Under section “How it works” I can eliminate bullets 2 and 3. And replace them with a bullet point about the update requiring .container within all navbars and how it simplifies the requirements for spacing and flex.

I updated all the code examples from div class="container-fluid" to div class="container" in lines 39, 89, 96, 122, 141, 170, 191, 229, 242, 256, 282, 294, 325, 354, 383, 456, 464, 472, 480, 496, 547, 577, 607, 645,

Then on section “containers” I change that paragraph to “All navbars require a .container within. You can also wrap an entire navbar with a .container which does not require any overrides and works across all devices.“

Also removed div class = “container-fluid” /div tag from the first example code in the “containers” section.

Hope you like the changes.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bravogeorge/patch-1