Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33624

Remove aria-haspopup from dropdowns

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Patrick H. Lauke requested to merge patrickhlauke-v4-aria-haspopup into v4-dev Apr 13, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 16

aria-haspopup="true" is really intended to signal that an ARIA menu will be opened on activation. as a result, some assistive technologies will announce controls with aria-haspopup="true" as a menu or menu item (e.g. JAWS and NVDA). In addition, aria-haspopup seems to trigger a bug in Edge/Narrator where the aria-expanded state is not correctly announced at the moment when aria-haspopup is present. This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01

Closes https://github.com/twbs/bootstrap/issues/33528

(Note this was already done at some early point in v5, with no adverse effect. As this only really affects the documentation/examples/tests, not the actual code, this is a non-breaking change)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: patrickhlauke-v4-aria-haspopup