Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33626

Fix v5 regressions in tab dropdown functionality

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/cpsievert/tab-dropdown-fixes into main Apr 13, 2021
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: cpsievert

Refs #33625 (closed) (fixes the 1st problem, at least)

I'd also be happy to help address the 2nd issue, but I'm not sure whether you'd prefer to just update the docs, or actually fix the Tab logic to support .dropdown-items wrapped in <li>

<ul class="dropdown-menu">
     <li><a class="dropdown-item" href="#">Action</a></li>
</ul>

To do the latter, looks as though we need to modify the 1st part of this logic to do something closer to const dropdownElement = element.parents(SELECTOR_DROPDOWN).find(CLASS_NAME_DROPDOWN_MENU)

https://github.com/twbs/bootstrap/blob/db32b2380c3040936b8e88f6d6dae5998750ddf6/js/src/tab.js#L165-L174

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/cpsievert/tab-dropdown-fixes