Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !33665

Scrollbar.js Sanitizations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed GeoSot requested to merge gs-scrollbar-sanitations into main Apr 17, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 8

Background: First Pr #33245 was to just decoupling scrollbar functionality form modal.js , coping the existing code as it was.

This Pr optimizes functionality:

  • Removes .modal-open class as it is already handled by scrollbar.js
  • _modal.scss make modal overflowY: auto by default (was on ``.modal-open`, which is the same)
  • scrollbar.js: keep initial body overflowY value as attribute and re-set it properly & test
  • scrollbar.js: avoid to create data-bs attributes for null values
  • Revisit modal, offcanvas & scrollbar tests
  • set the base to support different rootElement (than body) helping #33018 an #33574
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs-scrollbar-sanitations