Skip to content
GitLab

Add shift-tab keyboard support for dialogs (modal & Offcanvas components)

Merged Administrator requested to merge github/fork/RyanBerliner/dialog-focus into main

Created by: RyanBerliner

Fixes #28481 (closed)

  • Share focus trapping behavior between modal and Offcanvas components
  • Allow shift-tab keyboard navigation to wrap around backwards (go to the last focusable element)

There are a couple issues (primarily #33804) that aim to fix inconsistent screen reader navigation or announcements. The work I've done here only concerns tab navigation.

TODO:

  • Test and revise the focusableChildren selector
  • Fix isVisible utility function (tracking #33914 (closed))
  • Fix BrowserStack tests

Preview Modal Preview Offcanvas