Skip to content
GitLab

Use JSON.parse in dropdown.js for passing JSON as data attribute

Closed Administrator requested to merge github/fork/719media/patch-12 into main

Created by: 719media

@GeoSot

  1. There is literally only a try catch around a JSON.parse, before the config types are checked. I don't think it should be abstracted out at this point. Too simple.
  2. I did not throw an error, since it happens before "DefaultType" check as you mentioned, so the "DefaultType" check catches any errors anyway. So, I'm swallowing JSON.parse errors as before
  3. I'm not really sure this needs major testing, it's fairly straightforward to me, but let me know.

I guess the only question I have now is, is it worth it to Bootstrap author to include this? As a reminder, the whole point of this PR was to get popper to expose "strategy" parameter, which, IMO, is a commonly used parameter for popper integrations to escape overflow problems. Certainly this PR allows for more options, and it is fairly simple in code addition. I went ahead and added the same configuration to the only other component I saw using popper, tooltip.js