Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !34458

Dropdown cleanups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged GeoSot requested to merge gs-dropwdown-cleanups into main Jul 08, 2021
  • Overview 1
  • Commits 7
  • Pipelines 0
  • Changes 2
  • make dataApiKeydownHandler to handle specific instance, avoiding extra manipulations
  • extract createPopper method
  • handle click event in one place, remove undocumented click listener on element in case of not having the proper markup
  • use classList add instead of toggle on show
  • simplify toggle
  • remove static interface
  • make isShown method

NOTE for reviewers:

Better review it, commit by commit. It will help you with the proper message and will guide you with sanity to follow the logic

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs-dropwdown-cleanups