Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !34574

Document change to `hr` in v5

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge migration-guide-hr into main Jul 25, 2021
  • Overview 8
  • Commits 3
  • Pipelines 0
  • Changes 1

I'm not 100% convinced we should revert our <hr> changes to that of v4. First, it'd create some breaking changes or deprecations for the $hr-opacity variable. Second, it'd be a breaking change to move from support for .bg-* utilities to .border-* utilities for customizing the element. Just feels like a messy option either way. The border solution does perhaps provide crisper rendering when zooming, but I'm not sure that's enough to make the change.

For now, I've documented something about the change in our migration guide since we missed an entry for that.

Thoughts @twbs/css-review?


/x-ref #34374 (closed) and #34292 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: migration-guide-hr