Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !34924

v4: Disabled link cleanup (backport)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Patrick H. Lauke requested to merge v4-remove-not-recommended-aria-disabled into v4-dev Sep 08, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 16

manual backport of #34886

per https://www.w3.org/TR/html-aria/#docconformance

It is NOT RECOMMENDED to use aria-disabled="true" on an a element with an href attribute.

NOTE If a link needs to be "disabled", remove the href attribute.

This PR removes the unnecessary href="#", tabindex="-1", and aria-disabled="true" from disabled links in both docs pages and examples. aria-disabled="true" is kept for disabled link-based buttons (that have role="button") as there it's appropriate to use (you want to convey to assistive technologies that this thing you're claiming is a button is also disabled at the moment)

Further, the PR extends the "Link functionality caveat" to show the "proper" way (removing href and adding .disabled class only) to disable a link, but then explains what to do if that's not possible (and then keeps an example with all the traditional href="#" tabindex="-1" aria-disabled="true", but explains clearly that it's not ideal). Same sort of explanation is also added to the pointer event utilities page

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4-remove-not-recommended-aria-disabled