Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35004

Allow to customise form-switch colors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/flohw/feature/custom-switch-with-theme-colors into main Sep 17, 2021
  • Overview 23
  • Commits 11
  • Pipelines 0
  • Changes 3

Created by: flohw

Hi

I create updated this PR to fix issue #35001 (closed) I would like to submit this PR for any comments before taking it further. Hopefully it's the good thing to do. Feel free to add any feedback.

For example at the moment, contrast with other colors than white, not checked switch misses some contrast. Fixed with another variable $form-switch-bg-off-image which has an inverted color than the default one. (white instead of black basically)

Before updating the PR: image

After PR update: image

I also not make any changes for disabled input too. I didn't make any changes for disabled input but results looks good to me.

I only create this PR to know if I am in the good direction and if it has any chance to be merged.

I updated the documentation too. Let me know if some example needs to be removed and if the line 105 should not be wrapped. It has been done automatically by my IDE and leave as is as I didn't feel comfortable to horizontally scroll to read when editing.

Thanks

PS: my commit is not signed properly, I will sign it properly if I am allowed to go further.

closes #35001 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/flohw/feature/custom-switch-with-theme-colors