Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35274

Set isolate for unicode-bidi in code tags

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ebraminio/rm-override into main Oct 26, 2021
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ebraminio

bidi-override should almost never be used for any modern
html page as it actually flips and make illegible any
RTL text contained in LTR context and vice versa. This
switches it with isolate which likely was the intention
and improves the tags to work actually work in mixed
direction pages.

Spotted the issue while reading https://getbootstrap.com/docs/5.1/getting-started/rtl/#starter-template

image

The highlighted text is flipped and illegible, bidi-override shouldn't be used here at all as it has flipped the text contained in code tags making it completely unreadable. It should've been like this instead which is actually readable text:

image

See also similar issues got fixed by removing bidi-override,

  • My patch in WebKit's WebInspector, https://github.com/WebKit/WebKit/commit/4ed77fae3f6d0843e8ccb729a5bf17cae0d7e6f9 for this file https://bugs.webkit.org/show_bug.cgi?id=220241
  • https://github.com/ajaxorg/ace/issues/1429#issuecomment-35064710

This should be back ported also to every release branches with bidi-override use, https://github.com/twbs/bootstrap/commit/9488978fb55286ba83e8193a871d1ff9815045b9 CC from the change: @ffoodd @XhmikosR

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ebraminio/rm-override