Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35327

floating-labels: remove `aria-label` in the `select` example

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/scottaohara/patch-1 into main Nov 04, 2021
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: scottaohara

removes the aria-label on the floating label select example.

While it is understood that this is just an example, the visible text (label) of "Works with selects" and the aria-label="Floating label select example" created a WCAG 2.5.3 Label in name failure.

As the aria-label isn't necessary here since this select is already provided an accessible name by its label element, removing the unnecessary aria-label seems the best course of action as:

  • removing it solves the WCAG issue
  • it removes the potential implication to developers that they'd even need an aria-label here, let alone indirectly suggesting that it's ok for the visible text and accessible name to be out of alignment
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/scottaohara/patch-1