Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35442

Cleanup CSS var creation with Sass mixins and functions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Otto requested to merge css-vars-sass into main Dec 01, 2021
  • Overview 2
  • Commits 6
  • Pipelines 0
  • Changes 18

This PR cleans up the CSS variable creation, replacing most (all?) of them with Sass mixins and functions. The idea is to reduce the repetition of --#{$variable-prefix} and make generating :root-level variables much easier. This is still a little WIP while I confirm everything is still functional.

Todos and questions:

  • Is there a better way to handle RFS with the root-var() mixin and loop generation.
  • Review other instances and confirm I've covered all bases
  • Review output
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: css-vars-sass