Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35491

Rely on `border-width` for `<hr>` size

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge main-fod-hr into main Dec 08, 2021
  • Overview 3
  • Commits 7
  • Pipelines 0
  • Changes 7

Created by: ffoodd

Fixes #34292 (closed), fixes #34374 (closed), fixes #35616 (closed).

A few tries confirmed me that relying on border-width as in v4 doesn't imply any side effect, even when using the (deprecated) size attribute.

I don't see any reason to stick with height then, so ditching this to make our new hr closer to v4.

Contrary to what we said in #34574, we can keep the opacity feature this way. With my current proposal, customizing hr could be done using .text-* for color and .border-* for sizing. I'd stick to currentColor for color since it allows inheritance: relying on border-color would require us to define a value (as it was done in v4) but I think it's more valuable to inherit from text color, isn't it?

NB: the current migration guide mentions v5.2.0, which is not accurate, is it? Do we maintain a minor versions' migration guide anywhere?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-fod-hr