Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !3551

Swapped out .hasClass() with .is() when checking for multiple classes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jorgenfb/8dda83906d72ade81ecf9b21d55b5a2922589d30 into master May 20, 2012
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: jorgenfb

.hasClass() just checks if the classes appear in the exact order you specify, without any other classes inbetween. Using .is() ensures that you get a positive response even if classes are shuffled and/or mixed with other classes.

This seems to be a problem with some of the unit test for bootstrap-tooltip that was testing for: .hasClass("fade in") when the actual class would have been "fade top in" when the tooltip module failed. This would give the impression that the test passed when it actually failed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jorgenfb/8dda83906d72ade81ecf9b21d55b5a2922589d30