Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35808

Fix modal SASS when $spacer is of the pixels unit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/TomONeill/patch-1 into main Feb 08, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: TomONeill

Setting the $spacer variable to a pixels unit breaks the compilation due to a calculation that's happening in the modal SASS:

SassError: 8px and 0.25rem have incompatible units.
    ╷
131 │   padding: $modal-inner-padding - $modal-footer-margin-between * .5;
    │            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
  node_modules\bootstrap\scss\_modal.scss 131:12  @import
  .scss\bootstrap.scss 29:9                       @import

It's actually line 132 now (click).

Since it's half the size of the spacer, might as well calculate the size.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/TomONeill/patch-1