Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35886

Replace non-existent `--bs-btn-padding` by `--bs-btn-padding-{x|y}`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge github/fork/julien-deramond/main-jd-fix-buttons-css-vars into main Feb 23, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

--#{$variable-prefix}btn-padding doesn't exist so the custom sizing button with CSS variables is not fully functional.

In this fix, I chose to keep 2 separate vars but it could probably be only 1 var.

Preview


Note: there is another bug that can be seen in this page: the last buttons are not vertically aligned with the other buttons in a same row in the examples. It is probably due to the new rule in https://github.com/twbs/bootstrap/commit/37f3977e6d96e274cb73255d99e3e4ec60f03c0f:

> :not(hr):last-child {
  margin-bottom: 0;
}

Capture d’écran 2022-02-23 à 14 18 02

I can create an issue if needed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-fix-buttons-css-vars