Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35911

More CSS variables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Otto requested to merge even-more-root-vars into main Feb 26, 2022
  • Overview 1
  • Commits 8
  • Pipelines 0
  • Changes 28

This PR adds even more CSS variables to the root and various elements, including headings, links, code, kbd, and even our tables. Some of the changes here are duplicative of other efforts—e.g., dark mode's PR has some of these new border variables. I'll handle rebasing and any conflicts that arise from that. Also worth noting that there are a few new calc() functions being added to support math against CSS variables.

Also included here is a new reassigned Sass variable to shorten $variable-prefix to $prefix moving forward. I don't know why we went with something so long, but it's annoying to type out repeatedly and I'm not yet ready to implement functions or mixins to generate our CSS variables at this time.

Definitely recommend looking at these commits one-by-one during review to see what I'm after and how I'm handling things.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: even-more-root-vars