Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35943

Add missing root border opacity CSS var

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge github/fork/julien-deramond/main-jd-missing-bs-border-opacity-var into main Mar 03, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

It looks like there is an issue with the latest modifications of the border colors on the main branch. Let's add .border-warning in the documentation when .border is not used:

### Additive

{{< example class="bd-example-border-utils" >}}
<span class="border border-warning"></span>
<span class="border-top border-warning"></span>
<span class="border-end border-warning"></span>
<span class="border-bottom border-warning"></span>
<span class="border-start border-warning"></span>
{{< /example >}}

### Subtractive

{{< example class="bd-example-border-utils bd-example-border-utils-0" >}}
<span class="border-0 border-warning"></span>
<span class="border-top-0 border-warning"></span>
<span class="border-end-0 border-warning"></span>
<span class="border-bottom-0 border-warning"></span>
<span class="border-start-0 border-warning"></span>
{{< /example >}}

Here is the rendering:

Screenshot from 2022-03-03 13-20-07

We can see in the browser that --bs-border-opacity is not set in those cases:

Screenshot from 2022-03-03 13-20-16

This PR is a proposal to define a default value for this CSS var in _root.scss.

Note: if this modification is correct, I didn't know if you prefer to have the value stored in $border-opacity or not.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

N/A

Live preview

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-missing-bs-border-opacity-var