Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35976

Fix space between popover's arrow and triggering element

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge github/fork/julien-deramond/main-jd-fix-popover-arrow-margin into main Mar 09, 2022
  • Overview 4
  • Commits 3
  • Pipelines 0
  • Changes 1

This PR is a proposal to:

  • Fix the space between the popover's arrow and the triggering element.
  • Add --bs-popover-inner-border-radius as it is done for the dropdowns with --bs-dropdown-inner-border-radius

(Note: I can split the commits if needed)

Regarding the fix proposed here.

In https://github.com/twbs/bootstrap/commit/2e75ec3c41a54865caa48f46485a1c90b12b0de6 (and so in the main branch) we can observe this kind of modifications:

- bottom: subtract(-$popover-arrow-height, $popover-border-width);
+ bottom: calc((var(--#{$variable-prefix}popover-arrow-height)) * -1); // stylelint-disable-line function-disallowed-list

The substraction does not appear in the new calculation. So the rendering is slightly different:

Before

Preview: https://getbootstrap.com/docs/5.1/components/popovers/#four-directions

Screenshot from 2022-03-09 10-22-13

With the error (main branch)

Preview: https://twbs-bootstrap.netlify.app/docs/5.1/components/popovers/#four-directions

There is an extra spacing between the button and the arrow:

Screenshot from 2022-03-09 10-23-01

With the fix proposed in this PR

Preview: https://deploy-preview-35976--twbs-bootstrap.netlify.app/docs/5.1/components/popovers/#four-directions

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-fix-popover-arrow-margin