Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35983

Carousel tweaks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged GeoSot requested to merge gs/carousel-tweaks into main Mar 10, 2022
  • Overview 22
  • Commits 4
  • Pipelines 0
  • Changes 3

Continuing the js clearance, some more tweaks to finally reveal the missing js option (ride) and to remove some tricky actions

It seems that ride option:

Autoplays the carousel after the user manually cycles the first item. If set to 'carousel', autoplays the carousel on load.

However instead of ride, we had the unused slide option inside carousel.js

CC: @mdo, @XhmikosR, @ffoodd, @patrickhlauke This PR is kind of radical and I really need your feedback & eyes over it.

Thanks to @MewenLeHo #35978 (closed) too, who pointed a missed error of mine

Todo:

  • add tests

Closes #35978 (closed) refs #32640 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs/carousel-tweaks