Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !35996

Add some `calc()` for manipulating new CSS variable version of border-width

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge css-var-border-width-fixes into main Mar 10, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 3

We rely on some lazy Sass math like -$border-width, so in these early steps of migrating to CSS variables, we're bound to find some issues. In this case, we're generating bad CSS because of that lazy math (-var(--bs-border-width)). The fix is using calc() to multiply by -1. I thought about reverting the change for these instances, but it'd just be ducking the inevitable, so decided to push it here for now.

Fixes #35986 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: css-var-border-width-fixes