Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36058

Fix proposal for `.dropstart`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-dropstart-fix into main Mar 24, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

Related to #28997.

It's been a long time, but following what I read, the removal of nesting for .dropstart was something that was asked (and I found that a bit weird by reading the actual code done in #23860).

I know that the dropstart component works well atm and it shouldn't change, but I was asking myself if a solution like this could potentially work for you. I couldn't see any breaking change with my visual checks and my tests with nesting.

If you accept this changes and as it changes the html code, I don't know if there is anything more to change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-dropstart-fix