Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36075

Fix duplicate `.rounded-*` and `.fw-semibold` defs in examples

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge github/fork/julien-deramond/main-jd-fix-duplicate-rounded-and-fw-utilities-in-examples into main Mar 29, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 7

Description

https://github.com/twbs/bootstrap/commit/c73480c63660d0643434e07c9a522758c21a272d brings new .fw-semibold, .rounded-4 and .rounded-5 into Bootstrap. The refactoring of examples to use more utility classes defined those as well so this PR fixes the duplicates and reajust the values for .rounded-4 to .rounded-6 in examples due to the change of values.

  • .fw-semibold was defined in site/content/docs/5.1/examples/sidebars/sidebars.css and set to the same value 600 so can be removed
  • .rounded-4 was defined in site/layouts/_default/examples.html and set to .5rem which corresponds to the new value of .rounded-3 so I needed to switch all .rounded-4 in examples to .rounded-3.
  • .rounded-5 was defined in site/layouts/_default/examples.html and set to .75rem. There's no such value in the utilities so I dropped the class and set this value directly in the CSS files
    • Note: I slightly changed the value for the "Sign up for free" modal example.
  • .rounded-6 was defined in site/layouts/_default/examples.html and set to 1rem which corresponds to the new .rounded-4 utility set as well to 1rem (xl) so I needed to switch all .rounded-6 in examples to .rounded-4.

Motivation & Context

Fix the regressions in the examples

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

Related issues

N/A

Live previews

  • Dropdowns example in this PR vs. current dropdowns example
  • Features example in this PR vs. current features example
  • List groups example in this PR vs. current list groups example
  • Modals example in this PR vs. current modals example
  • Sidebars example in this PR vs. current sidebars example
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-fix-duplicate-rounded-and-fw-utilities-in-examples