Skip to content
GitLab

Move tooltip over SVG example from docs to visual tests

Closed Administrator requested to merge github/fork/tkrotoff/tooltip-svg-visual-tests into main

Created by: tkrotoff

Fixes https://github.com/twbs/bootstrap/issues/32715 https://github.com/twbs/bootstrap/issues/32715#issuecomment-886745329

Problem: the tooltip visual tests are already broken (not related to this PR).

Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '<img src=1 onerror=alert(123)>' is not a valid selector.

This is because of:

<button ... data-bs-container="<img src=1 onerror=alert(123)>">
  Tooltip with XSS container
</button>

Visual tests should be played by Playwright (or similar) to avoid this kind of breakage

FYI the original tooltip over SVG example was introduced here: https://github.com/twbs/bootstrap/pull/30928