Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36169

Handle disabled focused tabs with tab JavaScript plugin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge github/fork/julien-deramond/main-jd-disabled-tab-panes into main Apr 14, 2022
  • Overview 29
  • Commits 15
  • Pipelines 0
  • Changes 4

Since https://github.com/twbs/bootstrap/commit/135b9cdff2bb301e36faa9110043d5823f620b56, disabled tabs with tab JavaScript plugin don't seem to be handled anymore: they can be focused with the keyboard when disabled. I've read the discussion in https://github.com/twbs/bootstrap/pull/33079 but I was unsure of the current state.

This PR tries to reintegrate this behavior (heavily draft atm) or at least shows the issue.

Note: with this current code, it doesn't work if the first tab is disabled and there are some issues when they are active + disabled.

If we use this PR to fix this use case

  • Add tests
  • Handle active + disabled
  • First tab is disabled
  • Only disabled tabs

Live preview

/cc @GeoSot

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-disabled-tab-panes