Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36212

Doc: remove `role="group"` from some split drop* buttons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge github/fork/julien-deramond/main-jd-remove-split-dropdown-role-group into main Apr 23, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

Description

  • Remove role="group" from the split dropstart button in the documentation
  • Remove role="group" from visual JS tests

Motivation & Context

Since v4.6.1 (at least), the split dropstart button example in the documentation has a role="group". But this is the only example having it.

We don't see this role for split dropend and split dropup, and "normal" split buttons.

This PR brings more consistency in the examples by removing this extra-role.

⚠ However, I don't have the expertise to say if it could be useful in terms of a11y. In this case, this PR should rather be updated to add this role wherever it is useful.

Note: Since it is observed in v4.x as well, whatever the final modification will be, I suppose it could be backported in v4 as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Related issues

N/A

Live preview

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-remove-split-dropdown-role-group