Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36221

[WIP] Fix documentation versions selection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Julien Déramond requested to merge github/fork/julien-deramond/main-jd-docs-versions-urls into main Apr 25, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

This PR is for the moment a proposal to revert modifications added to handle the versions in the dropdown in the header.

Here are the issues that I can observe:

  • 🔴 Go to https://twbs-bootstrap.netlify.app/. Click on the versions dropdown, choose v5.0.2. You'll be redirected to https://getbootstrap.com/docs/5.0//main--twbs-bootstrap.netlify.app/. Same thing for v5.1.3.
  • 🔴 Go to https://twbs-bootstrap.netlify.app/docs/5.1/examples/. Click on the versions dropdown, choose v5.0.2. You'll be redirected to https://getbootstrap.com/docs/5.0/5.1/examples/. Same thing for v5.1.3.
  • 🟢 Go to https://twbs-bootstrap.netlify.app/docs/5.1/getting-started/accessibility/. Click on the versions dropdown, choose v5.0.2. You'll be redirected to https://getbootstrap.com/docs/5.0/getting-started/accessibility/.
  • 🟡 Go to https://twbs-bootstrap.netlify.app/docs/5.1/components/placeholders/. Click on the versions dropdown. v5.0.2 is disabled because this page didn't exist in v5.0. I find it a little bit disturbing (even if I understand this choice): if I want to go to the v5.0 documentation, I have to change my current page.
  • 🟡 Go to https://twbs-bootstrap.netlify.app/docs/5.1/utilities/opacity/. Click on the versions dropdown, choose v5.0.2. You'll be redirected to https://getbootstrap.com/docs/5.0/utilities/opacity/ with a 404 File not found.

Based on this obervation even if I understand perfectly the need I'm wondering if this system of keeping the context will be easy to maintain in the future. If we decide to change the doc or examples sitemaps, none of the links would work without a modification of the previous documentations.

Depending on when the v5.2.0 will be released, it could be safer to revert this mechanism and implement it with all the cases in v5.2.1 or v5.3.0. Thoughts?

/CC @mdo

Feel free to close this PR if it's already been discussed

Live preview

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/julien-deramond/main-jd-docs-versions-urls