Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36238

Revert `border-color` change

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge revert-border-color into main Apr 28, 2022
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 4

Problem with the translucent border-color via rgba() is that we often use negative margin and the like to overlap elements (like our input groups and table rows). As a result, some border segments get a doubled opacity, which is no bueno. Was worth trying out at least, but my dark mode work shows it's not working. 😅

Something to still figure out—should the default .border utilities use an rgba() value instead? I don't think we can just yet. Worth noting that we'll keep the local-vars on those default utilities as it sets --bs-border-opacity: 1 for the border-color utilities. This feels right as it's a bit of a shortcut for not having to redeclare the opacity on every utility, but maybe that's not right.

Edit: Actually we added a global --bs-border-opacity: 1, so we can perhaps remove it from the default utilities.

  • Add border-color-translucent variables and utilities?
  • Update dropdowns, modals, offcanvas, popovers, toasts
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: revert-border-color