Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36239

Iterate on border utilities

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge rm-border-opacity-from-utils into main Apr 28, 2022
  • Overview 7
  • Commits 3
  • Pipelines 0
  • Changes 3

We set --bs-border-opacity: 1 globally at the :root level, so redeclaring it on every .border-* utility doesn't make much sense. I think we can drop this.

Edit: Per conversation below, I've also removed the global --bs-border-opacity and restored it on the .border-{color} utilities. There's no need for border opacity on default .border utilities, just the color ones, which now properly matches our .text-{color} and .bg-{color} utilities. In addition, this rearranged the utilities map to put border-color at the end (without which .border-opacity-* classes wouldn't work properly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rm-border-opacity-from-utils