Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36366

add back focus box shadow to `btn-link`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/RyanBerliner/btn-link-focus-state into main May 16, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: RyanBerliner

5.2.0-beta1 looks to have accidentally dropped the box shadow around btn-link buttons on focus. You can see this by tab navigating to a btn-link on both 5.1.x and 5.2.0-beta1 and comparing

  • 5.2 beta button example
  • 5.1 button example

This is because the --#{$prefix}btn-focus-shadow-rgb variable is undefined in the context of btn-link. My solution here does involve code duplication from the button-variant() mixin - I'm certainly open to other solutions, however this illustrates the problem and a potential solution.

Preview link: https://deploy-preview-36366--twbs-bootstrap.netlify.app/docs/5.2/components/buttons/#examples

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/RyanBerliner/btn-link-focus-state