Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36398

JS: tests fixes & standardization of spies usage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-js-fixes into main May 19, 2022
  • Overview 4
  • Commits 3
  • Pipelines 0
  • Changes 18

Here are the issues concerning the CSS part, we encountered with @julien-deramond.

The commits can be splited if needed or wanted or even be in another PR. I'm open to every comment that could help fix these issues.

Tackled by the PR:

Typo with (https://github.com/twbs/bootstrap/pull/36398/commits/5b133f5206fbb2d2196d447217c94c5e7c71c2a6)

Carousel test typo error with maybeEnableCycle.

Test improvement with (https://github.com/twbs/bootstrap/pull/36398/commits/41c228b67715c26013f7ac048aa73d4c832a8a04)

Carousel test since the test looked weird to me (Calling the function and expected to be called)

Spy declaration with (https://github.com/twbs/bootstrap/pull/36398/commits/505175a553718f497ca6a07e0b4e4904ea8e6c49)

Make the spy declaration almost the same everywhere to be more consistent. Not sure if this is mandatory.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-js-fixes