Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36402

Scrollspy: add history state in every click, when `smoothScroll` options, is activated

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed GeoSot requested to merge gs/scrollspy-smoothscroll-option-use-browser-history into main May 19, 2022
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

As the new ScrollSpy smoothScroll option, prevents default action that in every user click, appends anchor hash on window.location, we can programmatically achieve the same attitude using history.pushstate

Any feedback will be appreciated.

Disclaimer: Just trying a suggestion/feature (I really do not know). I am not sure this PR adds any value in user experience

closes #36291 (closed) closes #36387

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs/scrollspy-smoothscroll-option-use-browser-history