Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36406

CSS: few proposals

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-css-fixes into main May 20, 2022
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 3

Here are the issues concerning the CSS part, we encountered with @julien-deramond.

The commits can be splited if needed or wanted or even be in another PR. I'm open to every comment that could help fix these issues.

Tackled by the PR:

!important with (https://github.com/twbs/bootstrap/pull/36406/commits/ca48cc8d18b07fd011bab5052e726dced8446b35)

This PR adds a check for important utilities. It doesn't change anything on Bootstrap side, but might be useful for people that don't want !important in their code. If this commit is approved, it might lead to refactor some helpers' scss files.

Border-*-0 with (https://github.com/twbs/bootstrap/pull/36406/commits/adc78d0c843b005c49eb2cf975d468f9f8af2cf9)

This PR tries to make the .border-*-0 utility more understandable. It could be useful too, since the Stackblitz example doesn't take into account the examples' classes.

Rounded numbers with (https://github.com/twbs/bootstrap/pull/36406/commits/dee2d265d9a706d86105db2e8b14c7374e816268)

Having a rounded number of pixels for people that use 1rem = 16px.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-css-fixes