Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36627

Fix search modal z-index to be on top of all docs showcased components

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-make-sure-search-modal-is-over-everything into main Jun 23, 2022
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

Search modal currently has a z-index set to 1030. That makes it under some showcased components in the documentation; especially the ones that stay displayed even if one clicks outside of it.

Here are two examples, popover and toast:

Screenshot from 2022-06-23 19-51-41 Screenshot from 2022-06-23 19-50-56

In _variables.scss we have this list of z-indexes:

$zindex-dropdown:                   1000 !default;
$zindex-sticky:                     1020 !default;
$zindex-fixed:                      1030 !default;
$zindex-offcanvas-backdrop:         1040 !default;
$zindex-offcanvas:                  1045 !default;
$zindex-modal-backdrop:             1050 !default;
$zindex-modal:                      1055 !default;
$zindex-popover:                    1070 !default;
$zindex-tooltip:                    1080 !default;
$zindex-toast:                      1090 !default;

I chose 2000 as a value here (maybe too extreme) just to be sure that it will always work in the future.

Live previews

  • Popover - Live demo
  • Toast - Live example

Thanks @louismaximepiton for this catch

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-make-sure-search-modal-is-over-everything