Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36689

Add missing CSS vars for `.navbar-nav`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-add-missing-css-var-for-navbar-nav into main Jul 06, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

While answering to https://github.com/twbs/bootstrap/issues/36684, I may have spotted an issue regarding the definition of --#{$prefix}nav-link-font-size and --#{$prefix}nav-link-font-weight in .navbar-nav.

Without this fix, locally, if you change this in _variables.css:

$nav-link-font-size:                30px !default;
$nav-link-font-weight:              700 !default;

The change is only observable in pages like /docs/5.2/components/navs-tabs/ that use .nav and .nav-links inside. The change is not observable in the main header of the docs for example that use .navbar-nav and .nav-linkss inside.

With this fix we can see the big bold font everywhere where we have .nav|.navbar-nav and .nav-links inside.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-add-missing-css-var-for-navbar-nav