Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36828

Fix pagination page items border radius

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-fix-pagination-border-radius into main Jul 24, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

Modify @if $pagination-margin-start == (calc($pagination-border-width * -1)) { to work like the recent fix done in https://github.com/twbs/bootstrap/commit/154916ca2e9160cc17c21c7a8e5938832ab186b3.

Motivation & Context

In some Sass compilers ($pagination-border-width * -1) == (calc($pagination-border-width * -1)) is evaluated to false and some users, like the issue's author, can see an unexpected border radius for .page-items in a pagination.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

Fixes #36820 (closed)

Live preview

  • Components > Pagination for non-regression
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-fix-pagination-border-radius